Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DALI tests compatible with Python 3.12 #5452

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Make DALI tests compatible with Python 3.12 #5452

wants to merge 5 commits into from

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented May 2, 2024

  • adds additional replacements for functions used by nose
    and removed in python 3.12

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • adds additional replacements for functions used by nose
    and removed in python 3.12

Additional information:

Affected modules and functionalities:

  • nose test wrapper
  • nose test utils

Key points relevant for the review:

Tests:

  • Existing tests apply
    • all nose tests
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-3958

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14688850]: BUILD STARTED

github-advanced-security[bot]
github-advanced-security bot found potential problems May 2, 2024
View reviewed changes
qa/nose_wrapper/__main__.py Fixed Show fixed Hide fixed
qa/nose_wrapper/__main__.py Fixed Show fixed Hide fixed
qa/nose_wrapper/__main__.py Fixed Show fixed Hide fixed
qa/nose_wrapper/__main__.py Fixed Show fixed Hide fixed
@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from d171b28 to 087d99c Compare May 2, 2024 09:28
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14689665]: BUILD STARTED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from 087d99c to 435bb70 Compare May 2, 2024 09:52
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14689899]: BUILD STARTED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from 435bb70 to 570cdb5 Compare May 2, 2024 11:20
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14691274]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14691274]: BUILD FAILED

mzient
mzient reviewed May 6, 2024
View reviewed changes
Acknowledgements.txt Outdated


BEOPEN.COM LICENSE AGREEMENT FOR PYTHON 2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to copy the old licenses, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, removed.

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from 3be23d3 to 9005014 Compare July 9, 2024 10:01
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16433703]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16433703]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16438647]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16438647]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16448204]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16448204]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16464005]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16464005]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16467715]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16467715]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16470922]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16470922]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16496138]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16496138]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16497985]: BUILD STARTED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from 9005014 to 2270d69 Compare July 11, 2024 12:32
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16638827]: BUILD FAILED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from ebb42e2 to 86c53c0 Compare July 16, 2024 14:38
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16640870]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16640870]: BUILD FAILED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from 86c53c0 to 285e470 Compare July 16, 2024 16:36
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16643823]: BUILD STARTED

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 16, 2024
View reviewed changes
dali/test/python/test_utils.py Outdated
@@ -13,7 +13,7 @@
# limitations under the License.

import nvidia.dali as dali
import nvidia.dali.types as types
import nvidia.dali.dali_types as dali_dali_types

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'dali_dali_types' is not used.
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16643823]: BUILD FAILED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from 285e470 to bd077f9 Compare July 16, 2024 17:58
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16646074]: BUILD STARTED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from bd077f9 to 51d08a0 Compare July 17, 2024 07:14
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16664668]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16664668]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16709337]: BUILD STARTED

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 18, 2024
View reviewed changes
dali/test/python/nose_utils.py


class empty_case(unittest.TestCase):
def nop():

Check notice

Code scanning / CodeQL

First parameter of a method is not named 'self' Note

Normal methods should have at least one parameter (the first of which should be 'self').
@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from 3cc5271 to e759243 Compare July 18, 2024 14:56
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16709484]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16709484]: BUILD FAILED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from e759243 to 312d1c2 Compare July 18, 2024 15:47
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16710799]: BUILD STARTED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from 312d1c2 to c580e21 Compare July 19, 2024 07:50
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16733234]: BUILD STARTED

@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from c580e21 to 6c0a8ea Compare July 19, 2024 13:59
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16740127]: BUILD STARTED

@JanuszL
Make DALI tests compatible with Python 3.12
d2a9760 
- adds additional replacements for functions used by nose
  and removed in python 3.12
- remove numpy version pinning as the <1.26 is not compatible
  with python 3.12

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Review fix
8d439ed 
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Review fix
789b6d0 
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
More fixes
e208cd3 
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Unpin librosa
8f7d1d7 
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL JanuszL force-pushed the make_test_python3.12_compat branch from 6c0a8ea to 8f7d1d7 Compare July 19, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stiepan stiepan stiepan left review comments

@mzient mzient mzient left review comments

Assignees

@stiepan stiepan

@mzient mzient

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JanuszL @dali-automaton @stiepan @mzient